refactor(tmux): flatten tmuxinator dir and improve tsh/tss - #935
Conversation
- Move tmuxinator ymls from config/tmuxinator/tmuxinator/ to config/tmuxinator/ - Update default.nix to reference each yml directly - Make tsh default to pane content search (drop --log) - Move session history log browsing to tss --log Entire-Checkpoint: 813d9926c401
|
You do not have enough credits to review this pull request. Please purchase more credits to continue. |
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughExpands tmuxinator configuration from a single entry to four separate YAML profile files, and refactors fish shell functions to implement pane-content-based search workflow and add session history log navigation capability. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant RipGrep as rg<br/>(search)
participant Fzf as fzf<br/>(selection)
participant Tmux as Tmux<br/>(session mgmt)
User->>RipGrep: Search pane content files<br/>(pane_dir + archive_dir)
RipGrep-->>Fzf: Return matching files
User->>Fzf: Select match with preview
Fzf-->>User: Return selected pane filename
User->>User: Parse filename for<br/>session & window index
User->>Tmux: Validate session exists
alt Session found
User->>Tmux: Switch/attach and<br/>select window
Tmux-->>User: Active session
else Session missing
User-->>User: Show archived<br/>pane content notice
end
sequenceDiagram
participant User
participant SessionLog as Session History<br/>Log File
participant Fzf as fzf<br/>(selection)
participant Tmux as Tmux<br/>(session mgmt)
User->>User: Invoke --log flag
User->>SessionLog: Validate log exists<br/>(~/.local/share/tmux/session-history.log)
alt Log found
SessionLog-->>Fzf: Return log entries
User->>Fzf: Select entry with preview
Fzf-->>User: Return session/window entry
User->>User: Parse session & window index
User->>Tmux: Validate session exists
alt Session active
User->>Tmux: Switch/attach and<br/>select window
else Session gone
User-->>User: Error: session not found
end
else Log missing
SessionLog-->>User: Error: log not found
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @shunkakinoki, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the management of tmuxinator configurations by flattening their directory structure and updating the NixOS configuration to reflect this change. Additionally, it refactors the tmux utility functions, Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Mesa DescriptionTL;DRFlattened tmuxinator configuration directory and updated What changed?
Description generated by Mesa. Update settings |
Entire-Checkpoint: ca682e18f222
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the tmuxinator configuration by flattening files into a single directory and enhances the tsh and tss Fish shell functions. The _tsh_function now focuses on searching tmux pane contents, and _tss_function handles session history browsing via --log. However, it introduces command injection vulnerabilities in both tsh and tss functions. This is due to the unsafe interpolation of user-controlled data, specifically the query in tsh and session history log content in tss --log, into shell commands executed by fzf without proper sanitization or escaping.
| | fzf --prompt="pane-search> " \ | ||
| --height=40% \ | ||
| --query="$query" \ | ||
| --preview="rg -n -- '$query' {} 2>/dev/null | head -80" \ |
There was a problem hiding this comment.
The query variable, derived from user-supplied arguments, is directly interpolated into the fzf --preview command string. Since fzf executes this command in a shell, an attacker can provide a query containing single quotes and shell metacharacters to execute arbitrary commands. For example, a query like foo' ; touch /tmp/pwned ; ' would result in the execution of touch /tmp/pwned.
| --height=40% \ | ||
| --tac \ | ||
| --no-sort \ | ||
| --preview='echo {}') |
There was a problem hiding this comment.
The fzf preview command echo {} uses the {} placeholder, which is replaced by the literal content of the selected line from the session history log. Since the log contains session names, window names, and paths that can be influenced by users or processes (e.g., by creating a tmux session with a malicious name), an attacker can inject shell commands into these fields to achieve command execution when the log is browsed via tss --log. For example, a session named $(touch /tmp/pwned) would cause the command to execute when highlighted in the fzf list.
Entire-Checkpoint: 4ef546b46c9b
Entire-Checkpoint: c0effc6047c2
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
home-manager/programs/fish/functions/_tsh_function.fish (1)
27-29: Add a guard for malformed pane filenames.If a file does not match the expected naming pattern,
widxcan be empty and tmux targeting becomes brittle. A small validation check improves resilience.Proposed fix
set -l parts (string split -- '--' $fname) + if test (count $parts) -lt 2 + echo "Could not parse session/window from pane file: $selected" + return + end set -l sess $parts[1] set -l widx $parts[2]🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@home-manager/programs/fish/functions/_tsh_function.fish` around lines 27 - 29, The split of fname into parts can produce an empty widx for malformed pane filenames; after computing parts, sess, and widx in _tsh_function.fish, add a guard that validates the split (e.g., ensure count of parts >= 2 and widx is non-empty) and handle the failure by printing an error/notice and returning early (or falling back) instead of proceeding to tmux targeting; reference the variables parts, sess, and widx to locate where to insert the check.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@home-manager/programs/fish/functions/_tsh_function.fish`:
- Around line 6-8: The current early return in _tsh_function.fish aborts when
pane_dir is missing even if archive_dir exists; change the logic so it only
returns when neither pane_dir nor archive_dir exist: update the check around the
"if not test -d \"$pane_dir\"" block (and the similar block around lines 12-13)
to test both pane_dir and archive_dir, proceeding when archive_dir exists (so
archive-only search is reachable) and only echoing "No pane content store..."
and returning when both are absent.
In `@home-manager/programs/fish/functions/_tss_function.fish`:
- Around line 22-25: The parsing of the tmux target token is fragile: replace
the rigid split-by-" " + index access (variables target, parts, sess, widx)
with defensive parsing and validation; first ensure $selected contains a token
with a session:window form, split the token on ':' into parts and check that
parts has at least 2 elements before assigning sess and widx, and if validation
fails log an error or return early instead of calling tmux commands (so the tmux
calls that use sess/widx are not run with empty values); update the code paths
that reference target, parts, sess, and widx to use the validated values only.
---
Nitpick comments:
In `@home-manager/programs/fish/functions/_tsh_function.fish`:
- Around line 27-29: The split of fname into parts can produce an empty widx for
malformed pane filenames; after computing parts, sess, and widx in
_tsh_function.fish, add a guard that validates the split (e.g., ensure count of
parts >= 2 and widx is non-empty) and handle the failure by printing an
error/notice and returning early (or falling back) instead of proceeding to tmux
targeting; reference the variables parts, sess, and widx to locate where to
insert the check.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (7)
config/tmuxinator/default.nixconfig/tmuxinator/desktop.ymlconfig/tmuxinator/mobile.ymlconfig/tmuxinator/primary.ymlconfig/tmuxinator/work.ymlhome-manager/programs/fish/functions/_tsh_function.fishhome-manager/programs/fish/functions/_tss_function.fish
| if not test -d "$pane_dir" | ||
| echo "No pane content store found at $pane_dir" | ||
| return |
There was a problem hiding this comment.
Archive-only search is currently unreachable.
Line [6] returns when pane_dir is missing, even if archive_dir exists. That breaks the intended “live + archived” behavior.
Proposed fix
- if not test -d "$pane_dir"
- echo "No pane content store found at $pane_dir"
- return
- end
+ set -l search_dirs
+ if test -d "$pane_dir"
+ set -a search_dirs "$pane_dir"
+ end
+ if test -d "$archive_dir"
+ set -a search_dirs "$archive_dir"
+ end
+ if test (count $search_dirs) -eq 0
+ echo "No pane content store found at $pane_dir or $archive_dir"
+ return
+ end
@@
- set -l selected (rg -l -- "$query" "$pane_dir" "$archive_dir" 2>/dev/null \
+ set -l selected (rg -l -- "$query" $search_dirs 2>/dev/null \Also applies to: 12-13
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@home-manager/programs/fish/functions/_tsh_function.fish` around lines 6 - 8,
The current early return in _tsh_function.fish aborts when pane_dir is missing
even if archive_dir exists; change the logic so it only returns when neither
pane_dir nor archive_dir exist: update the check around the "if not test -d
\"$pane_dir\"" block (and the similar block around lines 12-13) to test both
pane_dir and archive_dir, proceeding when archive_dir exists (so archive-only
search is reachable) and only echoing "No pane content store..." and returning
when both are absent.
| set -l target (string split ' ' $selected)[2] | ||
| set -l parts (string split ':' $target) | ||
| set -l sess $parts[1] | ||
| set -l widx $parts[2] |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
find . -type f -name "_tss_function.fish" | head -5Repository: shunkakinoki/dotfiles
Length of output: 122
🏁 Script executed:
cat -n ./home-manager/programs/fish/functions/_tss_function.fishRepository: shunkakinoki/dotfiles
Length of output: 3250
🏁 Script executed:
find . -name "*session-history*" -o -name "*tss*" | grep -E "(log|script|config)" | head -20Repository: shunkakinoki/dotfiles
Length of output: 47
🏁 Script executed:
rg "session-history" --type fish --type sh --type bashRepository: shunkakinoki/dotfiles
Length of output: 93
🏁 Script executed:
rg "session-history"Repository: shunkakinoki/dotfiles
Length of output: 355
🏁 Script executed:
cat -n ./home-manager/programs/tmux/session-logger.shRepository: shunkakinoki/dotfiles
Length of output: 1809
Harden log-entry parsing before using tmux targets.
Line 22 assumes a strict " " (two-space) delimiter and fixed field position [2]; if the log format is malformed or incomplete, $sess and $widx can be empty or invalid. This causes silent failures in the subsequent tmux commands (lines 27, 34, 36) because errors are suppressed. Parse the session:window token defensively and validate before use.
Proposed fix
- set -l target (string split ' ' $selected)[2]
- set -l parts (string split ':' $target)
- set -l sess $parts[1]
- set -l widx $parts[2]
+ set -l target (string match -r '[^[:space:]]+:[0-9]+' -- $selected)
+ if test -z "$target"
+ echo "Could not parse session/window from: $selected"
+ return 1
+ end
+ set -l parts (string split ':' -- $target)
+ set -l sess $parts[1]
+ set -l widx $parts[2]📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| set -l target (string split ' ' $selected)[2] | |
| set -l parts (string split ':' $target) | |
| set -l sess $parts[1] | |
| set -l widx $parts[2] | |
| set -l target (string match -r '[^[:space:]]+:[0-9]+' -- $selected) | |
| if test -z "$target" | |
| echo "Could not parse session/window from: $selected" | |
| return 1 | |
| end | |
| set -l parts (string split ':' -- $target) | |
| set -l sess $parts[1] | |
| set -l widx $parts[2] |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@home-manager/programs/fish/functions/_tss_function.fish` around lines 22 -
25, The parsing of the tmux target token is fragile: replace the rigid
split-by-" " + index access (variables target, parts, sess, widx) with
defensive parsing and validation; first ensure $selected contains a token with a
session:window form, split the token on ':' into parts and check that parts has
at least 2 elements before assigning sess and widx, and if validation fails log
an error or return early instead of calling tmux commands (so the tmux calls
that use sess/widx are not run with empty values); update the code paths that
reference target, parts, sess, and widx to use the validated values only.
…dows Entire-Checkpoint: 86d49837e63d
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
2 issues found across 7 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="home-manager/programs/fish/functions/_tss_function.fish">
<violation number="1" location="home-manager/programs/fish/functions/_tss_function.fish:22">
P2: Validate the parsed log entry before using it to build tmux targets; otherwise malformed lines can lead to empty session/window values and broken tmux commands.</violation>
</file>
<file name="home-manager/programs/fish/functions/_tsh_function.fish">
<violation number="1" location="home-manager/programs/fish/functions/_tsh_function.fish:11">
P1: This preview command is vulnerable to command injection. If `$query` contains a single quote (e.g., `user's`), it breaks the quoting in the shell command executed by `fzf`, potentially executing arbitrary code.
Escape single quotes in the query before passing it to the preview command.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| set -l query (string join ' ' $argv) | ||
| set -l selected (rg -l -- "$query" "$pane_dir" "$archive_dir" 2>/dev/null \ | ||
| | fzf --prompt="pane-search> " \ | ||
| --height=40% \ | ||
| --query="$query" \ | ||
| --preview="rg -n -- '$query' {} 2>/dev/null | head -80" \ | ||
| --preview-window=right:60%) |
There was a problem hiding this comment.
P1: This preview command is vulnerable to command injection. If $query contains a single quote (e.g., user's), it breaks the quoting in the shell command executed by fzf, potentially executing arbitrary code.
Escape single quotes in the query before passing it to the preview command.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At home-manager/programs/fish/functions/_tsh_function.fish, line 11:
<comment>This preview command is vulnerable to command injection. If `$query` contains a single quote (e.g., `user's`), it breaks the quoting in the shell command executed by `fzf`, potentially executing arbitrary code.
Escape single quotes in the query before passing it to the preview command.</comment>
<file context>
@@ -1,72 +1,35 @@
- --tac \
- --no-sort \
- --preview='echo {}')
+ set -l query (string join ' ' $argv)
+ set -l selected (rg -l -- "$query" "$pane_dir" "$archive_dir" 2>/dev/null \
+ | fzf --prompt="pane-search> " \
</file context>
| set -l query (string join ' ' $argv) | |
| set -l selected (rg -l -- "$query" "$pane_dir" "$archive_dir" 2>/dev/null \ | |
| | fzf --prompt="pane-search> " \ | |
| --height=40% \ | |
| --query="$query" \ | |
| --preview="rg -n -- '$query' {} 2>/dev/null | head -80" \ | |
| --preview-window=right:60%) | |
| set -l query (string join ' ' $argv) | |
| set -l query_escaped (string replace -a "'" "'\\''" "$query") | |
| set -l selected (rg -l -- "$query" "$pane_dir" "$archive_dir" 2>/dev/null \ | |
| | fzf --prompt="pane-search> " \ | |
| --height=40% \ | |
| --query="$query" \ | |
| --preview="rg -n -- '$query_escaped' {} 2>/dev/null | head -80" \ | |
| --preview-window=right:60%) |
| set -l target (string split ' ' $selected)[2] | ||
| set -l parts (string split ':' $target) | ||
| set -l sess $parts[1] | ||
| set -l widx $parts[2] |
There was a problem hiding this comment.
P2: Validate the parsed log entry before using it to build tmux targets; otherwise malformed lines can lead to empty session/window values and broken tmux commands.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At home-manager/programs/fish/functions/_tss_function.fish, line 22:
<comment>Validate the parsed log entry before using it to build tmux targets; otherwise malformed lines can lead to empty session/window values and broken tmux commands.</comment>
<file context>
@@ -1,4 +1,43 @@
+ return
+ end
+
+ set -l target (string split ' ' $selected)[2]
+ set -l parts (string split ':' $target)
+ set -l sess $parts[1]
</file context>
| set -l target (string split ' ' $selected)[2] | |
| set -l parts (string split ':' $target) | |
| set -l sess $parts[1] | |
| set -l widx $parts[2] | |
| set -l target (string split ' ' $selected)[2] | |
| set -l parts (string split ':' $target) | |
| if test -z "$target" -o (count $parts) -lt 2 | |
| echo "Malformed log entry: $selected" | |
| return | |
| end | |
| set -l sess $parts[1] | |
| set -l widx $parts[2] |
There was a problem hiding this comment.
4 issues found across 3 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="home-manager/programs/tmux/tmux.conf">
<violation number="1" location="home-manager/programs/tmux/tmux.conf:152">
P2: This rebinds the existing `K` resize-pane shortcut, so pane resize up via `Prefix+K` stops working. Pick a different key or update the resize binding accordingly to avoid a regression.</violation>
</file>
<file name="home-manager/programs/fish/functions/_tsk_function.fish">
<violation number="1" location="home-manager/programs/fish/functions/_tsk_function.fish:4">
P2: Using a double-space delimiter is fragile, as session or window names containing double spaces will break the parsing. Consider using a more robust delimiter like a tab character (`\t`) in both the tmux format strings and the split logic.</violation>
<violation number="2" location="home-manager/programs/fish/functions/_tsk_function.fish:5">
P1: The format string uses 3 spaces after 'window' (likely for alignment), but the parsing logic splits on 2 spaces (` `). This results in the `target` variable containing a leading space (e.g., `' s1:1'`), causing `tmux kill-window` to fail. Reduce to 2 spaces to match the delimiter.</violation>
<violation number="3" location="home-manager/programs/fish/functions/_tsk_function.fish:13">
P1: The `{}` placeholder is unquoted in the preview command. If a session name contains special characters (like parentheses `( )` in Fish), this allows command injection or causes syntax errors. Quote the placeholder to treat it as a string.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| --height=40% \ | ||
| --multi \ | ||
| --preview=' | ||
| set kind (string split " " {})[1] |
There was a problem hiding this comment.
P1: The {} placeholder is unquoted in the preview command. If a session name contains special characters (like parentheses ( ) in Fish), this allows command injection or causes syntax errors. Quote the placeholder to treat it as a string.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At home-manager/programs/fish/functions/_tsk_function.fish, line 13:
<comment>The `{}` placeholder is unquoted in the preview command. If a session name contains special characters (like parentheses `( )` in Fish), this allows command injection or causes syntax errors. Quote the placeholder to treat it as a string.</comment>
<file context>
@@ -0,0 +1,34 @@
+ --height=40% \
+ --multi \
+ --preview='
+ set kind (string split " " {})[1]
+ set target (string split " " {})[2]
+ if test "$kind" = session
</file context>
| # Build list: sessions and windows | ||
| set -l items (begin | ||
| tmux list-sessions -F 'session #{session_name}' 2>/dev/null | ||
| tmux list-windows -a -F 'window #{session_name}:#{window_index} #{window_name}' 2>/dev/null |
There was a problem hiding this comment.
P1: The format string uses 3 spaces after 'window' (likely for alignment), but the parsing logic splits on 2 spaces ( ). This results in the target variable containing a leading space (e.g., ' s1:1'), causing tmux kill-window to fail. Reduce to 2 spaces to match the delimiter.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At home-manager/programs/fish/functions/_tsk_function.fish, line 5:
<comment>The format string uses 3 spaces after 'window' (likely for alignment), but the parsing logic splits on 2 spaces (` `). This results in the `target` variable containing a leading space (e.g., `' s1:1'`), causing `tmux kill-window` to fail. Reduce to 2 spaces to match the delimiter.</comment>
<file context>
@@ -0,0 +1,34 @@
+ # Build list: sessions and windows
+ set -l items (begin
+ tmux list-sessions -F 'session #{session_name}' 2>/dev/null
+ tmux list-windows -a -F 'window #{session_name}:#{window_index} #{window_name}' 2>/dev/null
+ end)
+
</file context>
| bind H run-shell "tmux new-window 'fish -c _tsh_function'" | ||
|
|
||
| # Kill sessions/windows via fzf | ||
| bind K run-shell "tmux new-window 'fish -c _tsk_function'" |
There was a problem hiding this comment.
P2: This rebinds the existing K resize-pane shortcut, so pane resize up via Prefix+K stops working. Pick a different key or update the resize binding accordingly to avoid a regression.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At home-manager/programs/tmux/tmux.conf, line 152:
<comment>This rebinds the existing `K` resize-pane shortcut, so pane resize up via `Prefix+K` stops working. Pick a different key or update the resize binding accordingly to avoid a regression.</comment>
<file context>
@@ -148,6 +148,9 @@ bind W run-shell "tmux new-window 'fish -c _tsw_function'"
bind H run-shell "tmux new-window 'fish -c _tsh_function'"
+# Kill sessions/windows via fzf
+bind K run-shell "tmux new-window 'fish -c _tsk_function'"
+
# Extrakto (text extraction)
</file context>
| bind K run-shell "tmux new-window 'fish -c _tsk_function'" | |
| bind M run-shell "tmux new-window 'fish -c _tsk_function'" |
| function _tsk_function --description "Kill tmux sessions or windows via fzf" | ||
| # Build list: sessions and windows | ||
| set -l items (begin | ||
| tmux list-sessions -F 'session #{session_name}' 2>/dev/null |
There was a problem hiding this comment.
P2: Using a double-space delimiter is fragile, as session or window names containing double spaces will break the parsing. Consider using a more robust delimiter like a tab character (\t) in both the tmux format strings and the split logic.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At home-manager/programs/fish/functions/_tsk_function.fish, line 4:
<comment>Using a double-space delimiter is fragile, as session or window names containing double spaces will break the parsing. Consider using a more robust delimiter like a tab character (`\t`) in both the tmux format strings and the split logic.</comment>
<file context>
@@ -0,0 +1,34 @@
+function _tsk_function --description "Kill tmux sessions or windows via fzf"
+ # Build list: sessions and windows
+ set -l items (begin
+ tmux list-sessions -F 'session #{session_name}' 2>/dev/null
+ tmux list-windows -a -F 'window #{session_name}:#{window_index} #{window_name}' 2>/dev/null
+ end)
</file context>
1 participant
Summary
config/tmuxinator/tmuxinator/*.yml→config/tmuxinator/*.yml, updatingdefault.nixto reference each file directlytshdefault to pane content search (fzf over live + archived pane snapshots); optional arg pre-fills the querytss --logTest plan
tshopens fzf over pane content filestsh <query>pre-fills fzf with querytss --logbrowses session/window metadata logtssstill fuzzy-picks/creates sessions as before~/.config/tmuxinator/🤖 Generated with Claude Code
Summary by cubic
Flattened tmuxinator configs to config/tmuxinator/*.yml and updated Nix to reference each file. tsh now defaults to pane content search with rg previews (archived panes in bat); session history is now tss --log or tsw --log; added tsk to kill sessions/windows plus tmux Prefix+H (search) and Prefix+K (kill).
Written for commit f87cb97. Summary will update on new commits.